Skip to content

Conversation

@tverney
Copy link
Contributor

@tverney tverney commented Nov 4, 2024

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.messages.sendCodeResult
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.messages.sendSystemPrompt
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.messages.sendUpdatePlaceholder
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.messages.updateChatAnswer

Check warning

Code scanning / QDJVMC

Unused import directive Warning

Unused import directive
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.messages.sendSystemPrompt
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.messages.sendUpdatePlaceholder
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.messages.updateChatAnswer
import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.messages.updateFileComponent

Check warning

Code scanning / QDJVMC

Unused import directive Warning

Unused import directive

// Atm this is the only possible path as codegen is mocked to return empty.
if (filePaths.size or deletedFiles.size == 0) {
if (filePaths.size == 0 && deletedFiles.size == 0) {

Check notice

Code scanning / QDJVMC

Size zero check can be replaced with 'isEmpty()' Note

Size zero check can be replaced with 'isEmpty()'

// Atm this is the only possible path as codegen is mocked to return empty.
if (filePaths.size or deletedFiles.size == 0) {
if (filePaths.size == 0 && deletedFiles.size == 0) {

Check notice

Code scanning / QDJVMC

Size zero check can be replaced with 'isEmpty()' Note

Size zero check can be replaced with 'isEmpty()'
filePaths = filePaths,
deletedFiles = deletedFiles,
messageId = messageId,
suspend fun MessagePublisher.updateChatAnswer(tabId: String, messageId: String, message: String?, followUps: List<FollowUp>) {

Check warning

Code scanning / QDJVMC

Redundant 'suspend' modifier Warning

Redundant 'suspend' modifier
filePaths = filePaths,
deletedFiles = deletedFiles,
messageId = messageId,
suspend fun MessagePublisher.updateChatAnswer(tabId: String, messageId: String, message: String?, followUps: List<FollowUp>) {

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Function "updateChatAnswer" is never used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants